Updating dist/index.js #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is this supposed to do? I can't judge from an empty description. |
|
Description updated. The matrix in the "Validate action" workflow covers Dafny versions greater than and less than 3.10 on a both x64 and arm64 runners (across all OSs), so the current testing should be sufficient. Note: for sufficiently old versions of Dafny, they run through Mono, which is why the x64 version will work on arm64 runners. Not the case for newer Dafny, which is why we want this behavior. |
keyboardDrummer
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This amends @josecorella's fix #20 to download Dafny built for
x64on versions < 3.10.0 (the only arch we were building for) and Dafny built foros.arch()otherwise